https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2662
Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.r.mathieson@googlemai
| |l.com
--- Comment #2 from Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx> 2008-07-03 08:05:10 PDT ---
Your changes here seem to be mostly to #if 0 out those parts that were written
to handle Corrigendum 2.
Are those parts of Corrigendum 2 support incorrect? If so, should they not be
fixed? I note that include_cor2_changes is controlled by a boolean preference
setting for the protocol - do other parts of code protected by the same test
work properly?
I get the following warnings under my Linux build:
msg_ulmap.c: In function `UL_HARQ_Chase_Sub_Burst_IE':
msg_ulmap.c:688: warning: unused variable `generic_item'
msg_ulmap.c: In function `UL_HARQ_IR_CTC_Sub_Burst_IE':
msg_ulmap.c:737: warning: unused variable `generic_item'
msg_ulmap.c: In function `UL_HARQ_IR_CC_Sub_Burst_IE':
msg_ulmap.c:786: warning: unused variable `generic_item'
msg_ulmap.c: In function `MIMO_UL_Chase_HARQ_Sub_Burst_IE':
msg_ulmap.c:836: warning: unused variable `generic_item'
msg_ulmap.c: In function `MIMO_UL_IR_HARQ__Sub_Burst_IE':
msg_ulmap.c:896: warning: unused variable `generic_item'
msg_ulmap.c: In function `MIMO_UL_IR_HARQ_for_CC_Sub_Burst_UIE':
msg_ulmap.c:956: warning: unused variable `generic_item'
msg_ulmap.c: In function `MIMO_UL_STC_HARQ_Sub_Burst_IE':
msg_ulmap.c:1017: warning: unused variable `generic_item'
make: *** [msg_ulmap.lo] Error 1
Lastly, while grepping around in the plugin folder I noted:
msg_sbc.c:extern guint include_cor2_changes;
Its actually declared, and usually externed, as a gboolean.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
