Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 1124] Application level protocol PDUs not dissected properly if minimal header

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1124


Florent DROUIN <florent.drouin@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |florent.drouin@xxxxxxxxxx




--- Comment #14 from Florent DROUIN <florent.drouin@xxxxxxxxxx>  2008-03-19 10:04:36 GMT ---
I have tried this patch with a private dissector.
Instead of getting the minimal length required to decode the high layer PDU
header (when this header is too short), we try to get the whole next segment.
It seems to work.

In tcp_dissect_pdus() of epan/dissectors/packet-tcp.c
<<
      if (length_remaining < fixed_len) {
        /*
         * Yes.  Tell the TCP dissector where the data for this message
         * starts in the data it handed us, and how many more bytes we
         * need, and return.
         */
        pinfo->desegment_offset = offset;
        /* pinfo->desegment_len = fixed_len - length_remaining; */
        pinfo->desegment_len=DESEGMENT_ONE_MORE_SEGMENT;
        return;
      }
>>
What could be the drawback of using this method ?


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.