Wireshark-bugs: [Wireshark-bugs] [Bug 2263] new wireshark dissector for SERCOS III (ethertype 0x
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2263
Hans-Peter Bock <xbk@xxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #1571 is|0 |1
obsolete| |
Attachment #1576| |review_for_checkin?
Flag| |
--- Comment #6 from Hans-Peter Bock <xbk@xxxxxxxxxx> 2008-03-19 09:45:42 GMT ---
Created an attachment (id=1576)
--> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1576)
updated diff with all current issues addressed
Issue #3 (plugin)
Its not my own source but my job to deliver it to wireshark; the main developer
said that it was easier to write it as a plugin. So the answer to the question
with my current view of things is yes.
Issue #4 (C++ comments)
C++ style comments have been changed into C style comments.
Issue #5 (Unused function parameters)
All unused function parameters have been tagged with _U_.
Issue #6 (meaningful labels)
What do you mean with "i.s.o. constants"?
Issue #7 (fuzztest)
The plugin was not fuzztested. How do I run a fuzztest?
Issue #8 (ethertype)
ETHERTYPE_SERCOS from epan/etypes.h is now used.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
