Wireshark-bugs: [Wireshark-bugs] [Bug 2091] X25 reassembly when presenting out of order packets
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2091
Gerhard Olsson <gerhard.nospam@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #1257 is|0 |1
obsolete| |
Attachment #1561| |review_for_checkin?
Flag| |
--- Comment #3 from Gerhard Olsson <gerhard.nospam@xxxxxxxxx> 2008-03-17 12:53:57 GMT ---
Created an attachment (id=1561)
--> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1561)
Deliver all X25 packets with More set in one go to X25
The XOT dissector will request packets from the TCP stream until More flag is
set before delivering to X25. This makes sure that at least an "X25 packet
sequence" is handled correctly when X25 reassembles packets and deliver to
further dissectors.
The situation where the subdissector to X25 requires packets in order is not
handled. That must be implemented in XOT as well.
Note: This patch does not handle the presentation of reassembled packets. That
is another bug.
(This is not visible in the testcase, but referenced in 2091 (for TCP) and 2347
(for X25))
The patch works by using tcp_dissect_pdus, where the length required to dissect
an "xot sequence" depends on the x25 packets. tcp_dissect_pdus will therefore
be called multiple times for each "sequence".
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
