Ethereal-users: [Ethereal-users] Bug in rtcp dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jonathan Arnold <jdarnold@xxxxxxxxxxxx>
Date: Mon, 28 Nov 2005 21:20:49 -0500
There's a bug in the rtcp dissector, when it comes to dissecting SDES
PRIV entries.  In searching the site, I see that Skip Hansen posted the
one line fix for this May 2003, but looking at the source code, I don't
see it in there.  Here is Skip's fix to packet-rtcp.c:

--- snip ---
          proto_tree_add_string( sdes_item_tree, hf_rtcp_ssrc_prefix_string, tvb, offset, prefix_len,
prefix_string );
          free( prefix_string );
          offset += prefix_len;
          item_len -= prefix_len + 1; /* added line */
       }
       prefix_string = ( char * ) malloc( item_len + 1 );
       for ( counter = 0; counter < item_len; counter++ )
           prefix_string[ counter ] =
--- snip ---

I was wondering if there is any chance of getting this fix in for the next release?

--
Jonathan Arnold               (mailto:jdarnold@xxxxxxxxxxxx)
Jiggle The Handle, a personal blog    http://jiggle.anaze.us

Procrastination is the art of keeping up with yesterday.
- Don Marquis