|
ULFL,
ULFL wrote:
>> The row just below the tabs, containing e.g. "Error Values" is
>> completely useless, please remove it. This information is provided by
>> the tab labels.
Done
>> The label "Composite Expert Statistics" might also be simply removed, to
>> get more dialog space for the more important user data
Done
>> As I've done it e.g. in the Statistics/Conversations, please add the
>> number of occurrences to the tab labels, e.g.: "Errors: 11"
Done
>> Suggestion for a better column ordering: "Group / Protocol / Summary /
>> Count", at least the protocol should be before the summary, so you can
>> read e.g.: "TCP" "Window is full"
Done
>> Bug: The contents of the Group / Protocol columns are currently exchanged
Done
>> The dialog title should be "Composite Expert Info" like the menu item
Done
>> Idea for further development:
>> What about the idea of combining both dialogs into one e.g. by adding a
>> new "Details" or "Log" tab to your dialog?
Well, I have thought a lot about this one. I would like to see both the expert and composite expert included in one display window. Much like how Ethereal currently displays the protocol tree in the decode window with the plus symbol to expand the item to show the subitems. For example...
Group Protocol Info Count
[+] Sequence TCP Connection Request 2
When expanded it would show...
Group Protocol Info Count
[-] Sequence TCP Connection Request 2
Packet 10
Packet 25
Maybe even more information could be presented in the subtree data. But for now, not wanting to step on your toes and try to move your work into mine, I have included a new menu item when clicking on the packet within the composite expert info window. The new menu item is "Go to first occurance". This actually does the same as your expert info by positioning the trace within the Ethereal main window to the first occurance of the packet selected in the trace. So, if the user was actually wanting to see the packet that was being referenced in the window, all they need to do is highlight the expert info item, then right click and select the new option "Go to first occurance". I know this might not be a very good term to use but it was one that came off the top of my head and seemed applicable.
Attached is a complete set of files. Since they are not checked in I didn't want to send a diff from the last email, just in case you had a different version for one of my other uploads.
Greg Morris
| 
