Greg Morris wrote:
The following updates add the composite expert statistics to the
Analyze menu in Ethereal.
Hi Greg!
First of all, I like the idea of the composite info you've added. Sorry
for the late response, I'm just busy ...
As I'm a nitpicker ;-), there are some things which needs to be fixed
before check-in. As I don't have currently much time, I can't do it
myself, but may be able to assist you if you have questions.
Some general observations:
The row just below the tabs, containing e.g. "Error Values" is
completely useless, please remove it. This information is provided by
the tab labels.
The label "Composite Expert Statistics" might also be simply removed, to
get more dialog space for the more important user data
As I've done it e.g. in the Statistics/Conversations, please add the
number of occurrences to the tab labels, e.g.: "Errors: 11"
Suggestion for a better column ordering: "Group / Protocol / Summary /
Count", at least the protocol should be before the summary, so you can
read e.g.: "TCP" "Window is full"
Bug: The contents of the Group / Protocol columns are currently exchanged
The dialog title should be "Composite Expert Info" like the menu item
Ok, so far about the things that came to my mind when first looking at
the dialog.
Some things I still want to do:
try the various context menu items
have a look at the implementation itself (e.g. I hate code duplication)
try the performance with large capture files (I've done some extensive
work to keep the expert info dialog at an acceptable performance level)
Idea for further development:
What about the idea of combining both dialogs into one e.g. by adding a
new "Details" or "Log" tab to your dialog?
Again, the thing is looking good, but at least the general observations
should be fixed before a check-in ...
Regards, ULFL
