Ethereal-dev: Re: [Ethereal-dev] patch for packet-isakmp.c to fix decoding ikev2 payload

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Shoichi Sakane <sakane@xxxxxxxx>
Date: Thu, 29 Sep 2005 14:20:34 +0900
Hi,

Thank you for merging.

O.K. I will improve to use symbolic names that I added instead numbers.

Should I modify original codes written by others to fit this change ?

Related question, IKEv2 looks like ISAKMP, but it is partially different
from ISAKMP.  IKEv2 is not compatible to IKEv1.  It might be better
to separate the partial codes of IKEv2 from packet-isakmp.c.

> On Sat, Sep 24, 2005 at 11:53:33AM +0900, Shoichi Sakane wrote:
> > Hi, I fixed some bugs to decoding IKEv2 payloads.  the following things
> > have been checked at the IPsec bake off in Toronto this week.
> > 
> > 	- fixed decoding IP address in TS payload
> > 	- fixed decoding IPv6 address in ID payload
> > 	- fixed decoding IKEv2 Delete payload
> > 	- SPI printing
> > 
> > the attached file is the diff file from
> > epan/dissectors/packet-isakmp.c of 0.10.12
> 
> Checked in. Also checked in a change to make it compile. If you tested these
> changes I'm a bit astonished that the final diff was broken.
> 
> Just a wish: Can you make id_type and tstype into enums and use the symbolic
>   names instead of using the numbers and writing the meaning into comments
>   most of the time?