Checked in.
Brg
Anders
-----Ursprungligt meddelande-----
Från: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx] För David Richards
Skickat: den 5 augusti 2005 09:52
Till: Ethereal development
Ämne: [Ethereal-dev] Patch for packet-bacapp.c/h
Here are patches for packet-bacapp.c/h. It fixes a number of bugs and
eliminates a bunch of redundant code. There are still quite a few
problems, but they are in some of the less-used corners of BACnet.
For any BACnet folks out there, here are the highlights of what's fixed:
1) Decoding of vendor-defined types
2) Decoding of some event notification parameters (not all)
3) Decoding of ABSTRACT-SYNTAX&Type
4) Decoding of BACnetTimeStamp
5) Some problems with context-tagged values (like booleans)
6) Continuation segments - don't try to decode them since you can't
start mid-PDU
7) Removed some excessive levels of subtrees
And the major known problems left:
1) Certain BACnet property ID's a are mapped to specific types. This
breaks decoding of some vendor-defined objects.
2) Not all event parameters have been tested. Based on the ones that
have been tested, there are likely still issues elsewhere.
3) Packet highlighting is not consistent and is not always correct.
4) The tree is overly complicated (general opinion of people I have
polled on the subject).
5) Doesn't stop properly at end of first segment of a segmented PDU
(erroneously get malformed packet indication)
6) Related to #2, not all services have been tested.
7) Missing a bunch of BACnet 2004 stuff
