Ethereal-dev: SV: [Ethereal-dev] [patch] Ethereal 0.10.12 crashes in the ASN.1 plugin

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Anders Broman" <a.broman@xxxxxxxxx>
Date: Fri, 5 Aug 2005 21:32:40 +0200
Checked in.
Brg
Anders

-----Ursprungligt meddelande-----
Från: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx] För Thomas Steffen
Skickat: den 5 augusti 2005 15:09
Till: Ethereal development
Ämne: [Ethereal-dev] [patch] Ethereal 0.10.12 crashes in the ASN.1 plugin

Hello,

I am using the generic ASN.1 decoder plugin, and starting with the
0.10.12 it does not work any more. I have compiled a description table
with snacc, and specified this table in the ASN.1 preferences. When I
click on [Apply], Ethereal crashes. It also crashed one startup when
the two preferences asn1.file and asn1.pdu_name are defined.

This problem must have appeared in the last few weak, because I did
compile a subversion version about 3 weeks ago, and the worked fine. I
suspect that the problematic patch is Revision 15037.

Looking at the code, it seems that the following two lines in
packet-asn1.c are funny (5075-5076):
    udp_ports_asn1 = range_copy(global_udp_ports_asn1);
    udp_ports_asn1 = range_copy(global_udp_ports_asn1);
The last one should probably read sctp instead of udp.

With this change it works fine. A patch is attached, please apply.

Thomas