Hi,
I've tested it out.Dissector is generally working.Looks ugly as everything
no handmade but nevertheless:)
Some remarks:
1.No need to add ACSE title if this is not ACSE pdu(DATA blocks or whatever
) :
IMHO,the lines below has to be moved farther:
if (check_col(pinfo->cinfo, COL_PROTOCOL))
col_set_str(pinfo->cinfo, COL_PROTOCOL, "ACSE");
if (check_col(pinfo->cinfo, COL_INFO))
col_clear(pinfo->cinfo, COL_INFO);
I mean we have to say this is ACSE if PDU really has ACSE inside.For now we
have empty ACSE where we have no ACSE pdu at all.
For examle, FTAM data block without any ACSE pdu inside:
ISO 8073 COTP Connection-Oriented Transport Protocol
ISO 8327-1 OSI Session Protocol
ISO 8327-1 OSI Session Protocol
ISO 8823 OSI Presentation Protocol
ACSE <-------------- really we haven't ACSE here
OSI ISO 8571 FTAM Protocol
OCTET String
OSI ISO 8571 FTAM Protocol
OCTET String
OSI ISO 8571 FTAM Protocol
OCTET String
2.In case of unregistered high level dissector (MMS in this example) message
[Malformed Packet: ACSE] is not what I'm expecting to see.
No. Time Source Destination Protocol
Info
9 0.019827 204.254.125.152 192.168.1.36 ACSE
[Malformed Packet]
Frame 9 (200 bytes on wire, 200 bytes captured)
Ethernet II, Src: 00:30:a7:00:03:51 (00:30:a7:00:03:51), Dst:
00:05:32:49:f9:38 (00:05:32:49:f9:38)
Internet Protocol, Src: 204.254.125.152 (204.254.125.152), Dst: 192.168.1.36
(192.168.1.36)
Transmission Control Protocol, Src Port: tsap (102), Dst Port: 1033 (1033),
Seq: 23, Ack: 199, Len: 146
TPKT
ISO 8073 COTP Connection-Oriented Transport Protocol
ISO 8327-1 OSI Session Protocol
ISO 8823 OSI Presentation Protocol
ACSE
aare
Padding: 7
protocol-version: 80 (version1)
1... .... = version1: True
aSO-context-name: 1.0.9506.2.3
result: accepted (0)
result-source-diagnostic: acse-service-user (1)
acse-service-user: null (0)
user-information:
Item
indirect-reference: 3
encoding: single-ASN1-type (0)
BER: Dissector for OID:1.0.9506.2.3 not implemented. Contact Ethereal
developers if you want this supported
[9]
[0]
[Malformed Packet: ACSE]
Talking about MMS - probably it's time to generate such dissector? Now we
have everything we need.
Regards,
Yuriy.
Yuriy Sidelnikov wrote:
Hi,
Ok,I'll try to check new dissector ASAP.
It will take a while.
Yuriy.
ronnie sahlberg wrote:
Hi,
I have just checked in a new ACSE dissector generated by ASN2ETH.
Please test it out and report any issues.
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev
