Ethereal-dev: Re: [Ethereal-dev] SMPP: Multiple PDU's within one TCP packet

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Chris Wilson <chris@xxxxxxxxxxxxx>
Date: Sun, 18 Jan 2004 11:02:32 +0000
Hi Oliver,

> The whitespace stuff has to do with multiple contributors having
> different conventions for white space. A common convention seems to be
> 8 spaces for a tab and 4 space indentation, which was present in most
> of the SMPP dissector code.

Ok, I'll have another try at getting my editor to do something sensible with that :-)
 
> It's easier to compare if the code has been patched first and then a
> whitespace cleanup patch is done. I manually applied your 2nd patch
> and added some more information to the protocol tree and summary line.
> Some white-space clean-up has been done too.

Yes, the summary line looks much better like that.

Subsequent PDUs in one tvb are being dissected from (correct_offset + 16) in the version you've commited. I think there was also a bug in the patch that I sent you, so that when the SMPP GSM SMS dissector reassembled a multipart SMS, if both parts were in the same packet then the protocol tree would show the ressembled SMS twice.

I'll check it over and send you a patch later.

What are your thoughts about moving the "SMPP GSM SMS" out of packet-smpp.c and renaming it to "GSM SMS User Data", perhaps packet-gsm_sms_ud.c so that it can be used by Michael Lum's "GSM SMS" dissector and the UCP dissector?

Regards,

Chris