Ethereal-dev: Re: [Ethereal-dev] SMPP: Multiple PDU's within one TCP packet

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Olivier Biot" <ethereal@xxxxxxxxxx>
Date: Sun, 18 Jan 2004 01:37:13 +0100
Hi Chris,

The whitespace stuff has to do with multiple contributors having
different conventions for white space. A common convention seems to be
8 spaces for a tab and 4 space indentation, which was present in most
of the SMPP dissector code.

It's easier to compare if the code has been patched first and then a
whitespace cleanup patch is done. I manually applied your 2nd patch
and added some more information to the protocol tree and summary line.
Some white-space clean-up has been done too.

Regards,

Olivier

I'm looking at your patch
----- Original Message ----- 
From: "Chris Wilson" <chris@xxxxxxxxxxxxx>
To: "Ethereal Dev" <ethereal-dev@xxxxxxxxxxxx>
Sent: Saturday, January 10, 2004 7:39 PM
Subject: [Ethereal-dev] SMPP: Multiple PDU's within one TCP packet


|
| Hi all,
|
| For anyone whose interested... I've patched the SMPP dissector so
that it will dissect multiple SMPP PDUs within a single TCP packet (ie
for SMPP implementations that use a window size greater than 1).
|
| Attached are two patches, the first is just what indent did to get
rid of the mixture of spaces & tabs for indentation (was this
intentional?); the second is my actual patch.
|
|
| Regards,
|
| Chris
|


----------------------------------------------------------------------
----------


| _______________________________________________
| Ethereal-dev mailing list
| Ethereal-dev@xxxxxxxxxxxx
| http://www.ethereal.com/mailman/listinfo/ethereal-dev
|