Ethereal-dev: [Ethereal-dev] SMPP updates

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Biot Olivier <Olivier.Biot@xxxxxxxxxxx>
Date: Tue, 23 Dec 2003 01:16:34 +0100
[ Please ignore my previous patch; it was not final ]

Hi list,

Attached patch does the following:

* Move the GSM SMS dissection to a dedicated subdissector
* Now higher-level dissectors show up without the need
  of unfolding the SMPP dissector subtree
* Use the SMPP source and destination addresses for subdissection
* Move reassembly to GSM SMS, and fix duplicate "Reassembled in"
* Add debug logging to SMPP and SMPP GSM SMS dissector
* Get rid of the different UDH IE subtrees, and replace them with
  one subtree for all UDH IEs
* Add a new address type AT_STRINGZ (requires recompilation of
  all protocol dissectors)

NOTE: feel free to rename AT_STRINGZ into AT_STRING :)

TODO: see how we could merge Michael Lum's packet-gsm_sms.c code
with the code in packet-smpp.c.

I verified the patch with a big concatenation of traces, and it looks OK.

Please let me know it this patch is not acceptable,
otherwise I'll check it in.

Regards,

Olivier

Attachment: smpp.diff.gz
Description: Binary data