Ethereal-dev: [Ethereal-dev] SMPP updates

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Biot Olivier <Olivier.Biot@xxxxxxxxxxx>
Date: Tue, 23 Dec 2003 00:11:46 +0100
Hi list,

Attached patch does the following:

* Move the GSM SMS dissection to a dedicated subdissector
* Now higher-level dissectors show up without the need
  of unfolding the SMPP dissector subtree
* Use the SMPP source and destination addresses for subdissection
* Move reassembly to GSM SMS, and fix duplicate "Reassembled in"
* Add debug logging to SMPP and SMPP GSM SMS dissector

NOTE: feel free to rename AT_STRINGZ into AT_STRING :)

TODO: see how we could merge Michael Lum's packet-gsm_sms.c code
with the code in packet-smpp.c.

I verified the patch with a big concatenation of traces, and it looks OK.

Please review before checking in!

Regards,

Olivier

Attachment: smpp.diff.gz
Description: Binary data