Ethereal-dev: Re: [Ethereal-dev] bug with TCP relative sequence numbers and tcp desegment

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Wed, 16 Oct 2002 19:27:32 -0700
On Tue, Oct 15, 2002 at 10:48:37PM +0000, Pia Sahlberg wrote:
> I think the best solution would be to change it to use pinfo->fd->num as the 
> key to fragment_add() instead since
> it would provide a unique key for the PDU reassembly.
> (well almost unique, it could still fail if we get TCP encapsulated ontop of 
> TCP and both start a new PDU in the same frame)

...and the encapsulating and encapsulated connections are between the
same IP addresses, as the source and destination addresses are used in
the hash key, right?

If so, that'd probably reduce the chances of a collision either to zero
or to "close to zero unless you're doing something completely weird".