Ethereal-dev: Re: [Ethereal-dev] Removed unused parameters from packet-icq.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Thu, 2 May 2002 03:55:28 -0700
On Wed, May 01, 2002 at 06:48:34PM +0200, Joerg Mayer wrote:
> Would it be Ok to do the check for tree once in dissect_icq and remove it
> from all other functions?

Well, the "dissect_icqv[234]()" functions add stuff to the Protocol and
Info columns, so the check shouldn't be done in "dissect_icq()", it
should be done in the "dissect_icqv[234]()" functions, unless you move
the stuff to fill in the Protocol and Info columns into "dissect_icq()".