Wireshark · Ethereal-dev: [Ethereal-dev] Removed unused parameters from packet-icq.c

[Joerg Mayer <jmayer@xxxxxxxxx>]

see subject/changelog
   Jörg
--
Joerg Mayer                                          <jmayer@xxxxxxxxx>
I found out that "pro" means "instead of" (as in proconsul). Now I know
what proactive means.

Changelog: <jmayer@xxxxxxxxx>
	Remove all unused parameters from packet-icq.c

Index: ethereal/packet-icq.c
===================================================================
RCS file: /cvsroot/ethereal/packet-icq.c,v
retrieving revision 1.41
diff -u -r1.41 packet-icq.c
--- packet-icq.c	2002/04/08 20:23:55	1.41
+++ packet-icq.c	2002/05/01 16:29:03
@@ -459,9 +459,7 @@
 }
 
 static void
-dissect_icqv4(tvbuff_t *tvb,
-	      packet_info *pinfo,
-	      proto_tree *tree)
+dissect_icqv4(packet_info *pinfo)
 {
     /* Not really implemented yet */
     if (check_col(pinfo->cinfo, COL_PROTOCOL)) {
@@ -473,9 +471,7 @@
 }
 
 static void
-dissect_icqv3(tvbuff_t *tvb,
-	      packet_info *pinfo,
-	      proto_tree *tree)
+dissect_icqv3(packet_info *pinfo)
 {
     /* Not really implemented yet */
     if (check_col(pinfo->cinfo, COL_PROTOCOL)) {
@@ -487,9 +483,7 @@
 }
 
 static void
-dissect_icqv2(tvbuff_t *tvb,
-	      packet_info *pinfo,
-	      proto_tree *tree)
+dissect_icqv2(packet_info *pinfo)
 {
     /* Not really implemented yet */
     if (check_col(pinfo->cinfo, COL_PROTOCOL)) {
@@ -818,8 +812,7 @@
 static void
 icqv5_cmd_rand_search(proto_tree* tree, /* Tree to put the data in */
 		      tvbuff_t *tvb,    /* Decrypted packet content */
-		      int offset,       /* Offset from the start of the packet to the content */
-		      int size)         /* Number of chars left to do */
+		      int offset)       /* Offset from the start of the packet to the content */
 {
     guint16 group;
     proto_tree* subtree;
@@ -1008,8 +1001,7 @@
 icqv5_cmd_send_msg(proto_tree* tree,
 		   tvbuff_t *tvb,
 		   int offset,
-		   int size,
-		   int cmd)
+		   int size)
 {
     proto_tree* subtree;
     proto_item* ti;
@@ -1136,8 +1128,7 @@
 static void
 icqv5_cmd_no_params(proto_tree* tree, /* Tree to put the data in */
 		    tvbuff_t *tvb,    /* Decrypted packet content */
-		    int offset,       /* Offset from the start of the packet to the content */
-		    int cmd)
+		    int offset)       /* Offset from the start of the packet to the content */
 {
     proto_tree* subtree;
     proto_item* ti;
@@ -1165,9 +1156,7 @@
 static void
 icqv5_srv_no_params(proto_tree* tree, /* Tree to put the data in */
 		    tvbuff_t *tvb,    /* Packet content */
-		    int offset,       /* Offset from the start of the packet to the content */
-		    int size,         /* Number of chars left to do */
-		    int cmd)
+		    int offset)       /* Offset from the start of the packet to the content */
 {
     proto_tree* subtree;
     proto_item* ti;
@@ -1189,8 +1178,7 @@
 static void
 icqv5_srv_login_reply(proto_tree* tree,/* Tree to put the data in */
 		      tvbuff_t *tvb,   /* Tvbuff with packet */
-		      int offset,      /* Offset from the start of the packet to the content */
-		      int size)        /* Number of chars left to do */
+		      int offset)      /* Offset from the start of the packet to the content */
 {
     proto_tree* subtree;
     proto_item* ti;
@@ -1214,8 +1202,7 @@
 static void
 icqv5_srv_user_online(proto_tree* tree,/* Tree to put the data in */
 		      tvbuff_t *tvb,   /* Tvbuff with packet */
-		      int offset,      /* Offset from the start of the packet to the content */
-		      int size)        /* Number of chars left to do */
+		      int offset)      /* Offset from the start of the packet to the content */
 {
     proto_tree* subtree;
     proto_item* ti;
@@ -1271,8 +1258,7 @@
 static void
 icqv5_srv_user_offline(proto_tree* tree,/* Tree to put the data in */
 		      tvbuff_t *tvb,    /* Tvbuff with packet */
-		      int offset,       /* Offset from the start of the packet to the content */
-		      int size)         /* Number of chars left to do */
+		      int offset)       /* Offset from the start of the packet to the content */
 {
     proto_tree* subtree;
     proto_item* ti;
@@ -1822,14 +1808,12 @@
 	    icqv5_cmd_send_msg(icq_tree,
 			       decr_tvb,
 			       ICQ5_CL_HDRSIZE,
-			       pktsize - ICQ5_CL_HDRSIZE,
-			       cmd);
+			       pktsize - ICQ5_CL_HDRSIZE);
 	    break;
 	case CMD_RAND_SEARCH:
 	    icqv5_cmd_rand_search(icq_tree,
 				  decr_tvb,
-				  ICQ5_CL_HDRSIZE,
-				  pktsize - ICQ5_CL_HDRSIZE);
+				  ICQ5_CL_HDRSIZE);
 	    break;
 	case CMD_LOGIN:
 	    icqv5_cmd_login(icq_tree,
@@ -1875,8 +1859,7 @@
 	case CMD_QUERY_ADDONS:
 	    icqv5_cmd_no_params(icq_tree,
 				decr_tvb,
-				ICQ5_CL_HDRSIZE,
-				cmd);
+				ICQ5_CL_HDRSIZE);
 	    break;
 	default:
 	    proto_tree_add_text(icq_tree,
@@ -1986,26 +1969,22 @@
 	    icqv5_cmd_send_msg(icq_tree,
 			       tvb,
 			       offset + ICQ5_SRV_HDRSIZE,
-			       pktsize - ICQ5_SRV_HDRSIZE,
-			       cmd);
+			       pktsize - ICQ5_SRV_HDRSIZE);
 	    break;
 	case SRV_USER_ONLINE:
 	    icqv5_srv_user_online(icq_tree,
 			       tvb,
-			       offset + ICQ5_SRV_HDRSIZE,
-			       pktsize - ICQ5_SRV_HDRSIZE);
+			       offset + ICQ5_SRV_HDRSIZE);
 	    break;
 	case SRV_USER_OFFLINE:
 	    icqv5_srv_user_offline(icq_tree,
 			       tvb,
-			       offset + ICQ5_SRV_HDRSIZE,
-			       pktsize - ICQ5_SRV_HDRSIZE);
+			       offset + ICQ5_SRV_HDRSIZE);
 	    break;
 	case SRV_LOGIN_REPLY:
 	    icqv5_srv_login_reply(icq_tree,
 			       tvb,
-			       offset + ICQ5_SRV_HDRSIZE,
-			       pktsize - ICQ5_SRV_HDRSIZE);
+			       offset + ICQ5_SRV_HDRSIZE);
 	    break;
 	case SRV_META_USER:
 	    icqv5_srv_meta_user(icq_tree,
@@ -2034,9 +2013,7 @@
 	case SRV_UPDATE_SUCCESS:
 	    icqv5_srv_no_params(icq_tree,
 	    			tvb,
-				offset + ICQ5_SRV_HDRSIZE,
-				pktsize - ICQ5_SRV_HDRSIZE,
-				cmd);
+				offset + ICQ5_SRV_HDRSIZE);
 	    break;
 	default:
 	    proto_tree_add_text(icq_tree,
@@ -2089,13 +2066,13 @@
       dissect_icqv5(tvb, pinfo, tree);
       break;
   case 0x0004:
-      dissect_icqv4(tvb, pinfo, tree);
+      dissect_icqv4(pinfo);
       break;
   case 0x0003:
-      dissect_icqv3(tvb, pinfo, tree);
+      dissect_icqv3(pinfo);
       break;
   case 0x0002:
-      dissect_icqv2(tvb, pinfo, tree);
+      dissect_icqv2(pinfo);
       break;
   default:
       fprintf(stderr, "ICQ: Unknown version (%d)\n", version);