Wireshark · Ethereal-dev: Re: [Ethereal-dev] small keyboard request

[Heikki Vatiainen <hessu@xxxxxxxxx>]

Guy Harris <guy@xxxxxxxxxx> writes:

> "tree_view_select_row_cb()" could keep track of the currently selected
> row, and the callback for key-press-event could use that.
> 
> We do the same for additional packet windows; this means we'd have to
> keep track of *multiple* selected rows in *different* CTree widgets if
> we did that.  It may be easier to do this the way we are doing it now.

My first approach was using "tree-select-row" signal but I soon
noticed that e.g. opening a new packet window made the "remember the
last row" method fail. I kept toggling wrong rows and getting
assertion failures when row numbers were incorrectly mixed up between
unrelated CTree widgets.

I thought a little about keeping track of ctrees and their currently
selected rows, but then looked for an alternated method since the
CTree widget already knows about its currently selected row/rows.

This exercise did not feel wery keyboard friendly from GTK's part.

Thanks for checking in the patch.

-- 
Heikki Vatiainen                  * hessu@xxxxxxxxx
Tampere University of Technology  * Tampere, Finland