Ethereal-dev: Re: [Ethereal-dev] New Dissector : SSL/TLS

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Scott Renfro <scott@xxxxxxxxxx>
Date: Wed, 11 Jul 2001 12:11:23 -0700
On Wed, Jul 11, 2001 at 11:25:09AM -0700, Guy Harris wrote:
> 
> Checked in.

Thanks.

> [snip]
> 
> I've changed the code to do that.

Thanks, I'll check out those changes.

> if you want to put a time stamp into the protocol tree, use
> "proto_tree_add_time()" ...  Also, there's a "plurality()" macro

Ah, cool -- much more readable.

> In addition, not only must COL_INFO be set before anything is fetched
> from the tvbuff, so must COL_PROTOCOL, so that, if an exception is
> thrown due to, for example, a too-short capture length, the columns
> reflect the protocol being dissected, not the protocol above it.

Good point.  Up until the latest private revision, I was catching the
exceptions, if one occurred, and setting COL_PROTOCOL in a FINALLY
block.  When I killed that off, I forgot to add the initial col_set_str
back in at the start.

cheers,
--Scott

-- 
Scott Renfro <scott@xxxxxxxxxx>                          +1 650 862 4206