> The first (PATCH-connect) adds support for the CONNECT type of HTTP
> request. It also adds DELETE and OPTIONS to the hf_http_request
> proto_tree.
Checked in.
> The second adds an "Apply filter immediately" checkbox to the to the
> filters prefs page. It saves the value in the filters file, instead of
> in the preferences file (where it belongs). I figured that that's not too
> big of a deal, since the parser on other versions will just ignore it.
The way the filter preferences page is used in Ethereal is a bit odd.
I'd tried your patch with the "Edit:Preferences" menu item, and it did
nothing.
It turned out that was because, if you pop up the preferences dialog
through that path, and select a filter and hit OK, that doesn't
automatically set the filter in the filter text entry.
However, we also use the filter preferences page as, in effect, a list
of filters to choose from, and it *does* work there.
Should the "Filter:" buttons that let you browse the list of filters pop
up the filter preferences dialog?
I.e., is there any point in offering the full panoply of filter editing
functions, *and* other preference editing functions, at that point?
Or should it, instead, pop up just a list of filters, showing the
filter's name and contents, and, if you got the browsable list through
the "Filter:" button on the main window, *automatically* apply the
filter - or, perhaps, have a button other than "OK" to specify that the
filter in question should be selected *and* applied?
