Wireshark · Ethereal-cvs: [ethereal-cvs] cvs commit: ethereal/gtk stream_prefs.h print_prefs.h packet_win.h help_dlg.h

[Laurent Deniel <deniel@xxxxxxxxxxxx>]

deniel      2000/08/11 08:33:43 CDT

  Modified files:
    gtk                  stream_prefs.h print_prefs.h packet_win.h 
                         help_dlg.h follow_dlg.h dlg_utils.h 
                         gui_prefs.h main.h capture_dlg.c 
                         prefs_dlg.h colors.h stream_prefs.c 
                         print_prefs.c print_dlg.c gui_prefs.c 
                         goto_dlg.c find_dlg.c file_dlg.c 
                         column_prefs.c prefs_dlg.c main.c 
                         filter_prefs.c summary_dlg.c 
                         simple_dialog.c display_opts.c 
                         plugins_dlg.c help_dlg.c follow_dlg.c 
                         colors.c color_dlg.c 
  Log:
  Miscellaneous code cleaning
  
  - add <stdarg.h> or <varargs.h> in snprintf.h
    and remove those inclusions in the other #ifdef NEED_SNPRINTF_H codes
  
  - remove the check of multiple inclusions in source (.c)  code
    (there is a bit loss of _cpp_ performance, but I prefer the gain of
     code reading and maintenance; and nowadays, disk caches and VM are
     correctly optimized ;-).
  
  - protect all (well almost) header files against multiple inclusions
  
  - add header (i.e. GPL license) in some include files
  
  - reorganize a bit the way header files are included:
  
    First:
    #include <system_include_files>
    #include <external_package_include_files (e.g. gtk, glib etc.)>
    Then
    #include "ethereal_include_files"
  
    with the correct HAVE_XXX or NEED_XXX protections.
  
  - add some HAVE_XXX checks before including some system header files
  
  - add the same HAVE_XXX in wiretap as in ethereal
  
  Please forgive me, if I break something (I've only compiled and regression
  tested on Linux).
  
  Revision  Changes    Path
  1.2       +5 -1      ethereal/gtk/stream_prefs.h
  1.4       +5 -1      ethereal/gtk/print_prefs.h
  1.3       +6 -1      ethereal/gtk/packet_win.h
  1.2       +6 -1      ethereal/gtk/help_dlg.h
  1.2       +5 -1      ethereal/gtk/follow_dlg.h
  1.4       +6 -1      ethereal/gtk/dlg_utils.h
  1.2       +5 -1      ethereal/gtk/gui_prefs.h
  1.16      +2 -4      ethereal/gtk/main.h
  1.30      +1 -6      ethereal/gtk/capture_dlg.c
  1.4       +1 -3      ethereal/gtk/prefs_dlg.h
  1.3       +1 -6      ethereal/gtk/colors.h
  1.2       +1 -16     ethereal/gtk/stream_prefs.c
  1.6       +1 -17     ethereal/gtk/print_prefs.c
  1.20      +1 -16     ethereal/gtk/print_dlg.c
  1.5       +1 -7      ethereal/gtk/gui_prefs.c
  1.10      +1 -3      ethereal/gtk/goto_dlg.c
  1.14      +1 -3      ethereal/gtk/find_dlg.c
  1.30      +1 -19     ethereal/gtk/file_dlg.c
  1.2       +1 -8      ethereal/gtk/column_prefs.c
  1.17      +3 -1      ethereal/gtk/prefs_dlg.c
  1.133     +7 -6      ethereal/gtk/main.c
  1.16      +5 -1      ethereal/gtk/filter_prefs.c
  1.6       +1 -6      ethereal/gtk/summary_dlg.c
  1.5       +1 -6      ethereal/gtk/simple_dialog.c
  1.14      +5 -10     ethereal/gtk/display_opts.c
  1.16      +5 -1      ethereal/gtk/plugins_dlg.c
  1.2       +4 -6      ethereal/gtk/help_dlg.c
  1.4       +7 -6      ethereal/gtk/follow_dlg.c
  1.5       +4 -1      ethereal/gtk/colors.c
  1.6       +4 -1      ethereal/gtk/color_dlg.c