Ethereal-cvs: [ethereal-cvs] cvs commit: ethereal/wiretap toshiba.h snoop.h radcom.h n

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Laurent Deniel <deniel@xxxxxxxxxxxx>
Date: Fri, 11 Aug 2000 08:32:52 -0500 (CDT)
deniel      2000/08/11 08:32:50 CDT

  Modified files:
    wiretap              toshiba.h snoop.h radcom.h ngsniffer.h 
                         netxray.h nettl.h netmon.h libpcap.h 
                         lanalyzer.h iptrace.h i4btrace.h csids.h 
                         buffer.h ascend.h configure.in 
                         config.h.win32 file.c wtap-int.h buffer.c 
                         wtap.h ascend.c 
  Log:
  Miscellaneous code cleaning
  
  - add <stdarg.h> or <varargs.h> in snprintf.h
    and remove those inclusions in the other #ifdef NEED_SNPRINTF_H codes
  
  - remove the check of multiple inclusions in source (.c)  code
    (there is a bit loss of _cpp_ performance, but I prefer the gain of
     code reading and maintenance; and nowadays, disk caches and VM are
     correctly optimized ;-).
  
  - protect all (well almost) header files against multiple inclusions
  
  - add header (i.e. GPL license) in some include files
  
  - reorganize a bit the way header files are included:
  
    First:
    #include <system_include_files>
    #include <external_package_include_files (e.g. gtk, glib etc.)>
    Then
    #include "ethereal_include_files"
  
    with the correct HAVE_XXX or NEED_XXX protections.
  
  - add some HAVE_XXX checks before including some system header files
  
  - add the same HAVE_XXX in wiretap as in ethereal
  
  Please forgive me, if I break something (I've only compiled and regression
  tested on Linux).
  
  Revision  Changes    Path
  1.3       +6 -1      ethereal/wiretap/toshiba.h
  1.8       +6 -1      ethereal/wiretap/snoop.h
  1.5       +6 -1      ethereal/wiretap/radcom.h
  1.8       +6 -1      ethereal/wiretap/ngsniffer.h
  1.5       +6 -1      ethereal/wiretap/netxray.h
  1.5       +6 -1      ethereal/wiretap/nettl.h
  1.7       +6 -1      ethereal/wiretap/netmon.h
  1.9       +6 -1      ethereal/wiretap/libpcap.h
  1.4       +6 -1      ethereal/wiretap/lanalyzer.h
  1.5       +6 -1      ethereal/wiretap/iptrace.h
  1.2       +6 -1      ethereal/wiretap/i4btrace.h
  1.2       +6 -1      ethereal/wiretap/csids.h
  1.7       +6 -1      ethereal/wiretap/buffer.h
  1.7       +6 -1      ethereal/wiretap/ascend.h
  1.22      +2 -2      ethereal/wiretap/configure.in
  1.5       +9 -0      ethereal/wiretap/config.h.win32
  1.60      +9 -2      ethereal/wiretap/file.c
  1.6       +3 -2      ethereal/wiretap/wtap-int.h
  1.10      +3 -1      ethereal/wiretap/buffer.c
  1.77      +3 -1      ethereal/wiretap/wtap.h
  1.17      +3 -1      ethereal/wiretap/ascend.c