Ethereal-cvs: Re: [ethereal-cvs] cvs commit: ethereal proto.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Thu, 10 Aug 2000 15:40:06 -0500
On Thu, Aug 10, 2000 at 03:15:16PM -0500, Laurent Deniel wrote:
> 
> Laurent Deniel wrote:
> 
> The way multiple inclusions are checked is bad (in proto.c for instance)
> Multiple inclusions shall be checked in the header file itself not in
> the source code like in :
> 
> #ifndef __RESOLV_H__
> #include "resolv.h"
> #endif
> 
> #ifndef __REGISTER_H__
> #include "register.h"
> #endif
> 
> since if those names changes ... (and code reading is not easy).
> 
> This way should be only used when there is no other option (badly written
> system include files for instance ...)

That's my fault; one day I felt like coding like that, with some minor
justification --- it's one less file for cpp to open. But I could care less,
if you feel strongly about it, we can go back to the easier-to-read style.

--gilbert