Ethereal-cvs: Re: [ethereal-cvs] cvs commit: ethereal proto.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Thu, 10 Aug 2000 15:37:26 -0500
On Thu, Aug 10, 2000 at 03:03:10PM -0500, Laurent Deniel wrote:
> 
> 1) in almost all other source code, there is :
> 
> #ifdef NEED_SNPRINTF_H
> # ifdef HAVE_STDARG_H
> #  include <stdarg.h>
> # else
> #  include <varargs.h>
> # endif
> # include "snprintf.h"
> #endif
> 
> 2) if a service (i.e. snprintf) can not be used without including
>    some other header files, why not simply add
> 
> # ifdef HAVE_STDARG_H
> #  include <stdarg.h>
> # else
> #  include <varargs.h>
> # endif
> 
> in our snprintf.h file ?

There's no reason not to do #2. We started one way, and everyone
copy & pasted code.

--gilbert