Wireshark-users: Re: [Wireshark-users] bad handling of DHCP option 90?
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: stefan puiu <stefan.puiu@xxxxxxxxx>
Date: Thu, 26 Apr 2007 21:56:12 +0000 (UTC)
Jaap Keuter <jaap.keuter@...> writes:

> 
> Hi,
> 
> I reworked the patch a little:
> - No C++ comments
> - No need to check for size < 11, that is already done
> - Changed the comparison to the value taken from the value_string

I've tested the change against the current svn and some captures I have and it
worked - had a bit of trouble compiling at work in my VMWare Linux install,
since gcc would ICE, but it works at home. 

The warning goes away for discover messages alright; messages not using HMAC-MD5
and delayed authentication still have 11 as the minimum size, etc. One thing
worth considering is limiting the size of the AUTH option in DHCPDISCOVER
messages to 11. 

Stefan. 

> 
> Not much changes this way. Hope you can check it out before we commit
> this. I don't have a sample capture.
> 
> Thanx,
> Jaap