Wireshark · Wireshark-dev: Re: [Wireshark-dev] First patch submission (extcap install flags for silent mode)

[Graham Bloice <graham.bloice@xxxxxxxxxxxxx>]

On Tue, 12 May 2020 at 05:35, chuck c <bubbasnmp@xxxxxxxxx> wrote:

https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcChange.html

"Ask the wireshark-dev mailing list before you start a new development task."

I have modified wireshark.nsi to add flags for loading individual extcap binaries in silent mode.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16562

This allows the user to install if desired but doesn't burden all installs with them.

1. Ok to proceed in the submission process?

2. Ok to update the file that builds this section of user's guide in the same patch?

https://www.wireshark.org/docs/wsug_html_chunked/ChBuildInstallWinInstall.html

3. The extcap help files on Windows are not found:

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15592

Moving them to the same directory as the binaries would fix this.

Do in this patch or since it's a different bug make a different patch?

Process still seems a bit daunting to get from my hard drive to an eventual release.

Thanks in advance for any guidance or tips.

chuckc

Another resource for general info about submissions can be found on the Wiki: https://wiki.wireshark.org/Development/SubmittingPatches

And answers to your questions:

1. Go ahead.
2. Seems a good idea.
3. Yep, separate change.

--

Graham Bloice