Wireshark · Wireshark-dev: Re: [Wireshark-dev] issue to set up an RTP conversation

[Pascal Quantin <pascal@xxxxxxxxxxxxx>]

Hi Nicolas,

Le ven. 22 mars 2019 à 12:53, Bertin Nicolas <nicolas.bertin@xxxxxxxxxxxxxxxxx> a écrit :

Hello,

I've a dissector (packet-ua3g) that calls rtp_add_address(...) to set up an RTP conversation.

It was working but now it fails. I've checked on master, 3.0.0 (windows) and 2.6.6 (ubuntu 14.04)

I've found it's due to pinfo->fd->visited being already set (strp_add_address(...) function)  that

prevents the conversation to be added.

    /*
     * If this isn't the first time this packet has been processed,
     * we've already done this work, so we don't need to do it
     * again.
     */
    if ((pinfo->fd->visited) || (rtp_handle == NULL) || (rtp_rfc4571_handle == NULL))
    {
        return;
    }

I can workaround by clearing the "visited" bit before calling rtp_add_address(...) but I don't think

it's correct...

Any comments?

So why is your dissector not calling rtp_add_address() on first pass? Is it itself called or not when tree is NULL?

Best regards,

Pascal.