Wireshark-dev: Re: [Wireshark-dev] Lua minimum version
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Peter Wu <peter@xxxxxxxxxxxxx>
Date: Wed, 19 Dec 2018 23:05:11 +0100
On Wed, Dec 19, 2018 at 09:53:48AM +0100, Dario Lombardo wrote:
> Hi,
> which is the lua minimum version supported?

CMake says:
 * LUA (required version >= 5.1)


> The commit
> 
> commit 5953756305388724545f0df46d286be2f02c048a
> Author: Guy Harris <guy@xxxxxxxxxxxx>
> Date:   Mon Dec 17 10:57:20 2018 -0800
> 
>     Add routines to load Lua programs that assume the path is UTF-8 on
> Windows.
> 
> used lua_load with 5 params, that was introduced in lua 5.2 (if I'm not
> mistaken). Centos ships with lua 5.1, resulting in failing builds on that
> platform that has lua_load with 4 params only.

IMO that commit should be reverted, it extends the public Lua API just
to workaround an issue on Windows. We already override dofile/loadfile,
so I'm investigating whether that can be patched in an appropriate way.
(Aside from that there is also io.open, so the current fix is already
incomplete.)
-- 
Kind regards,
Peter Wu
https://lekensteyn.nl