How difficult can life be? Or my super bumpy road to a check-in, which caused a lot of frustration on the way. This is intended for possible improvements of the developer guides. Sometimes it helps to get feedback from someone with little perception and little previous knowledge on the topics. In that sense, less distributed documentation would have help me a little.
Yes I jumped between three environments, Cygwin, regular windows console, powershell, and git extension GUIs. Only that way I made micro steps in understanding of how things are glued together.
After the fact
- Mention early on also in the win32 guide, that if one plans to submit one shall start differently.
- If ‘SubmittingPatches’ would cover win32/gitextension that probably would have been the most effective way.
This needs to be read early on as well
Regards
David
===
I’ve read many items, and after the fact probably in the wrong order.
https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html
https://www.wireshark.org/develop.html
https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html#ChSrcSend
https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcObtain.html#ChSrcGit
https://wiki.wireshark.org/Development/SubmittingPatches
http://git-extensions-documentation.readthedocs.io/en/latest/remote_feature.html
https://makandracards.com/makandra/1303-how-to-use-git-on-windows-with-putty
https://stackoverflow.com/questions/34261492/how-to-push-for-gerrit-review-via-git-extension
My path:
- Git a git clone, modified code and tested it. So far so good.
- I now have two IDs registered with wireshark’s gerrit.
- Uploaded two different SSH keys to code.wireshark.org, because the Cygwin ssh is not used by Git Extensions
- Cygwin: managed to do a git clone
- CMD Console: Failed to ‘git clone’ from an ssh repository. Finally figured, that I need GIT_SSH as environment variable
- CMD Console: First start of ‘git clone’ one cannot confirm ‘y’ to actually cache the key (plink text is redirected to git
- Cached remote key using putty.exe (of course is not installed with Git Extensions)
- CMD Console: Managed to perform a new git clone ssh://username@xxxxxxxxxxxxxxxxxx:29418/wireshark
- Git Extensions: Modified Remote Repository to use ssh://username@xxxxxxxxxxxxxxxxxx:29418/wireshark
- Git Extensions: Got a code review error on my Publish Gerrit change due to a mismatch in email address
- Tried to register new email, got ‘Code -Review error Invalid Token’ on eMail confirmation link, work around that one. Tried about all browsers.
- CMD Console: Did a branch & copied modified code into it.
- Git Extensions: got a ‘missing change-Id in commit message footer‘. Commit to refs/publish/master/test. Looks wrong.
- Cygwin: stuck at ‘git review’ with SCP and permission denied (publickey). Grr. As this is yet another layer using python, it does not find/use plink.exe/pscp. Ok. Back to CMD/GUI
- Git Extensions: Try a regular push to /refs/for/master : ‘fatal: remote part of refspec is not a valid name in refs/heads/bug-14415:refs/heads//refs/for/master’
- Git Extensions: Push for Gerrit ‘Do you want to add a tracking reference’ yes -> still does not work
- Git Extensions: Install hook -> still does not work, awkward message about amend. Ok lets read more.
- Git Extensions: commit again with little ‘Amend’ option
- Finally. Done.
- Well I thought I was done. I already get the first comments …
