Wireshark · Wireshark-dev: [Wireshark-dev] Should I add new commits to address review comments?

Wireshark-dev: [Wireshark-dev] Should I add new commits to address review comments?

From: Richard Sharpe <realrichardsharpe@xxxxxxxxx>

Date: Tue, 11 Jul 2017 09:10:31 -0700

Hi folks,

Last time I made a change I created a new commit based on review
comments and then squashed the two commits, but that caused issues.

Is it better to simply submit the new commit or do I need to ensure I
keep the original change-id in the commit?

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)

Follow-Ups:
- Re: [Wireshark-dev] Should I add new commits to address review comments?
  - From: Graham Bloice
- Re: [Wireshark-dev] Should I add new commits to address review comments?
  - From: Pascal Quantin

Prev by Date: Re: [Wireshark-dev] Using Google Protobuf to Export Full Packet Dissection Data via Named Pipe
Next by Date: Re: [Wireshark-dev] Should I add new commits to address review comments?
Previous by thread: Re: [Wireshark-dev] Using Google Protobuf to Export Full Packet Dissection Data via Named Pipe
Next by thread: Re: [Wireshark-dev] Should I add new commits to address review comments?
Index(es):
- Date
- Thread