Wireshark-dev: Re: [Wireshark-dev] wiretap plugin
From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Wed, 10 May 2017 12:03:02 +0200
Hi Anders,

That is good to know. I’ll setup a cmake build as well (on Debian GNU/Linux).

Thanks,
Jaap


> On 10 May 2017, at 10:53, Anders Broman <anders.broman@xxxxxxxxxxxx> wrote:
> 
> Hi,
> Plugin.c is generated but with make it does not generate 
> 
> WS_DLL_PUBLIC_DEF void
> register_wtap_module(void)
> {
> 
> It looks like, it works with cmake...(at least on Wimdows)
> Regards
> Anders
> 
> 
> -----Original Message-----
> From: Wireshark-dev [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Jaap Keuter
> Sent: den 9 maj 2017 17:14
> To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
> Subject: Re: [Wireshark-dev] wiretap plugin
> 
> Hi Anders,
> 
> Thanks for having a look. This all seems quite in order. 
> Was this carried over from an older build, ie. is that plugin.c file recent? Does it get regenerated when moved out of the way?
> I’ll try testing this further tonight.
> 
> Thanks,
> Jaap
> 
> 
>> On 9 May 2017, at 16:46, Anders Broman <anders.broman@xxxxxxxxxxxx> wrote:
>> 
>> Hi,
>> In the folder where I have the plugin, plugin.c has the line
>> * Generated automatically from C:\Development\ewireshark\trunk\tools\make-dissector-reg.py.
>> It also has
>> WS_DLL_PUBLIC_DEF void
>> register_wtap_module(void)
>> {
>> :
>> 
>> I think I have modified the following files:
>> CMakeListsCustom.txt
>> plugins/CMakeListsCustom.txt
>> plugins/Custom.m4
>> plugins/Custom.make ( 3 places)
>> packaging/nsis/custom_plugins.txt
>> 
>> 
>> The Cmake file in the plugin folder has:
>> register_dissector_files(plugin.c
>> 	plugin_wtap
>> 	${DISSECTOR_SRC}
>> )
>> 
>> 
>> Regards
>> Anders
>> 
>> 
>> 
>> -----Original Message-----
>> From: Wireshark-dev [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On 
>> Behalf Of Jaap Keuter
>> Sent: den 9 maj 2017 13:48
>> To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
>> Subject: Re: [Wireshark-dev] wiretap plugin
>> 
>> Hi Anders,
>> 
>> Are you sure? I’m concerned about the generation of plugin.c. From 
>> reading plugins/Makefile.am.inc it seems that it only generates for 
>> dissector plugins (keyword: plugin), not for wiretap plugins (keyword: 
>> plugins_wtap)
>> 
>> #
>> plugin.c: $(REGISTER_SRC_FILES) $(top_srcdir)/tools/make-dissector-reg.py
>>       @echo Making plugin.c
>>       @$(PYTHON) $(top_srcdir)/tools/make-dissector-reg.py $(srcdir) \
>>               plugin $(REGISTER_SRC_FILES)
>> 
>> 
>> Thanks,
>> Jaap
>> 
>> 
>> 
>> 
>>> On 9 May 2017, at 12:08, Anders Broman <anders.broman@xxxxxxxxxxxx> wrote:
>>> 
>>> Hi,
>>> It's in the same files as other custom plugins. Top level 
>>> CMakeListCustom.txt etc Regards Anders
>>> 
>>> -----Original Message-----
>>> From: Wireshark-dev [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On 
>>> Behalf Of Jaap Keuter
>>> Sent: den 9 maj 2017 11:12
>>> To: Developer support list for Wireshark 
>>> <wireshark-dev@xxxxxxxxxxxxx>
>>> Subject: [Wireshark-dev] wiretap plugin
>>> 
>>> Hi list,
>>> 
>>> Does anyone currently have a wiretap plugin setup for building in current master?
>>> It seems that the plugin Makefile abstractions (plugins/Makefile.am.inc) are geared to dissector plugins, while tools/make-dissector-reg is still capable of making a plugin_wtap as well. And I haven’t even looked at CMake yet. 
>>> Can anyone share an example collection of current build files for a wiretap plugin?
>>> 
>>> Thanks,
>>> Jaap
> 
> 
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe