Wireshark · Wireshark-dev: Re: [Wireshark-dev] adding a new nvme dissector - pre-commit verifications

[Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>]

Hi Carmi,

There the pre-commit tools check (on tools folder)

You can look https://wiki.wireshark.org/Development/SubmittingPatches#Setup ( Git Pre-Commit Hook chapiter)

Cheers

On Wed, Jan 25, 2017 at 12:26 AM, Nitzan Carmi <nitzanc@xxxxxxxxxxxx> wrote:

Hi,

 

At the past month I've been working on a new dissector for Wireshark, to parse NVME protocol (with a focus on the fabrics channel – Infiniband/RDMA).

So far, although not all commands are fully parsed yet (lots of commands to cover), the dissection flow is working correctly, thus I think I reached a milestone and

this is a good time to share the code and take comments before I continue.

But, since I am new to Wireshark, I would like to know (and save everybody's time) if there are things I need to check or pay attention to

(beyond the fuzz testing I already read about) Before I push my dissector to gerrit for review.

 

Thanks!

Nitzan.

 

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe