Wireshark · Wireshark-dev: Re: [Wireshark-dev] Allowing --with-release to take hex strings ...

[Richard Sharpe <realrichardsharpe@xxxxxxxxx>]

On Thu, Jan 12, 2017 at 4:38 AM, Alexis La Goutte
<alexis.lagoutte@xxxxxxxxx> wrote:
> Hi Richard,
>
> I think it is not a problem...
>
> Please push your fix on Gerrit

OK, I will try to get that done this week. For the moment, to prevent
collisions between upstream and what I am doing I used another sed -e
'blah-blah' to do this.

> On Wed, Jan 11, 2017 at 10:29 PM, Richard Sharpe
> <realrichardsharpe@xxxxxxxxx> wrote:
>>
>> Hi folks,
>>
>> Does anyone have a problem with a change like this:
>>
>> diff --git a/configure.ac b/configure.ac
>> index d45f259..eeac905 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -58,7 +58,7 @@ AC_ARG_WITH([release],
>>  AC_HELP_STRING( [--with-release=@<:@1/no/4/5@:>@],
>>        [set release-number in package @<:@default=1@:>@]),
>>         with_release="$withval", with_release=1)
>> -re="^[[0-9]]+$"
>> +re="^[[0-9a-f]]+$"
>>  if [[[ "$with_release" =~ $re ]]]; then
>>          RELEASE="$with_release"
>>  else
>> --
>> 2.3.6
>>
>>
>> --
>> Regards,
>> Richard Sharpe
>> (何以解憂？唯有杜康。--曹操)
>>
>> ___________________________________________________________________________
>> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>> Archives:    https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>
>> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe



-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)