Wireshark · Wireshark-dev: Re: [Wireshark-dev] checklicenses.py

[Guy Harris <guy@xxxxxxxxxxxx>]

On Aug 5, 2016, at 2:31 PM, Guy Harris <guy@xxxxxxxxxxxx> wrote:

> 	'test/run_and_catch_crashes' has non-whitelisted license 'UNKNOWN'
> 	'macosx-support-lib-patches/qt-fix-pc-files' has non-whitelisted license 'UNKNOWN'
> 	'macosx-support-lib-patches/qt-fix-pc-file' has non-whitelisted license 'UNKNOWN'
> 
> They were missing copyright notices.  I added some.

Fixed.

> 	'tools/asn2deb' has non-whitelisted license 'GPL (v2 or later) GPL (v2 or later) (with incorrect FSF address)'
> 	'tools/idl2deb' has non-whitelisted license 'GPL (v2 or later) GPL (v2 or later) (with incorrect FSF address)'
> 
> Address fixed, hopefully that'll make it happy.

No, it's still annoyed because the initials GPL appear more than once in the file, or something such as that.  It should do a better job of detecting actual *licenses* as opposed to, for example

scriptinfo = """asn2deb version 2004-02-17
Copyright 2004, W. Borgert
Free software, released under the terms of the GPL."""

or

    create_file("debian/copyright",
            """This package has been created automatically be asn2deb on
%s for Debian GNU/Linux.

Wireshark: http://www.wireshark.com/

Copyright:

GPL, as evidenced by existence of GPL license file \"COPYING\".
(the GNU GPL may be viewed on Debian systems in
/usr/share/common-licenses/GPL)
""" % (iso))