Wireshark-dev: Re: [Wireshark-dev] Sign extension bug in proto_tree_set_uint64?
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Date: Mon, 6 Jun 2016 16:41:29 +0200
Hi Jens,

2016-06-06 16:02 GMT+02:00 Kilian, Jens <jens.kilian@xxxxxxxxxxxxx>:
Hi all,
I'm trying to define some header fields of type FT_UINT64 which have non-zero bitmasks (they all sit inside the same 64-bit word).  These fields are sign extended when displayed, which is not what I expected.  The sign extension happens in epan/proto.c, function proto_tree_set_uint64().

Comparing the 32-bit and 64-bit, and signed/unsigned variants of this function, it seems to me that this is a bug, possibly caused by forgetting to remove the sign extension code when proto_tree_set_int64 was added in commit e2bcee6a.  Am I right, or is this behavior intended?

yes this seems to be a copy/paste error and as the 64 bits variants are rather new, this might have been unnoticed.
Could you push a patch proposal to Gerrit (https://wiki.wireshark.org/Development/SubmittingPatches) ?

Thanks,
Pascal.