Wireshark · Wireshark-dev: Re: [Wireshark-dev] README.plugins regarding menus incorrect?

[Paul Offord <Paul.Offord@xxxxxxxxxxxx>]

Thanks Alexis.

 

I’ll try to do as you asked, but as I hadn’t heard of gerrit until you responded it may take me some time L

 

From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Alexis La Goutte
Sent: 26 November 2015 13:27
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Subject: Re: [Wireshark-dev] README.plugins regarding menus incorrect?

 

 

 

On Thu, Nov 26, 2015 at 2:18 PM, Paul Offord <Paul.Offord@xxxxxxxxxxxx> wrote:

Hi,

 

The notes in section 6 of README.plugins show examples of menu entries.  An example is:

 

ext_menubar_add_entry(ext_menu, "TestEntry2", "Test Entry 2",

            NULL, menu_cb, <user_data>);

 

But using this example causes an IntelliSense error in VS indicating there are too many parameters.  The extern definition in plugin_if.h is:

 

WS_DLL_PUBLIC void ext_menubar_add_entry( ext_menu_t * parent_menu, const gchar *label,

        const gchar *tooltip, ext_menubar_action_cb callback, gpointer user_data);

 

The disputed area seems to be that the example indicates a label and a unique name are needed, but the definition shows just a label.  Looking at the code it seems that the name is now generated in ext_menubar_add_generic_entry like this:

 

/* Create unique name, which is used by GTK to provide the menu */

entry->name = g_strdup_printf("%sI%02d", parent->name, parent->item_cnt);

 

·        Is this a bug in the README.plugins instructions?

·        Should I report it as a bug or are the READMEs maintained in some other way?

 

Hi Paul,

I think it is a bug on documentation...

You can push directly a fix on code review (gerrit)

 

Thanks and regards…Paul

 

______________________________________________________________________

This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system.

Any views or opinions expressed are solely those of the author and do not necessarily represent those of Advance Seven Ltd. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this message, which arise as a result of e-mail transmission.

Advance Seven Ltd. Registered in England & Wales numbered 2373877 at Endeavour House, Coopers End Lane, Stansted, Essex CM24 1SJ

______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com
______________________________________________________________________

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

 

______________________________________________________________________

This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system.

Any views or opinions expressed are solely those of the author and do not necessarily represent those of Advance Seven Ltd. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this message, which arise as a result of e-mail transmission.

Advance Seven Ltd. Registered in England & Wales numbered 2373877 at Endeavour House, Coopers End Lane, Stansted, Essex CM24 1SJ

______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com
______________________________________________________________________