Wireshark · Wireshark-dev: Re: [Wireshark-dev] Code Contribution

[Adam Pridgen <adam.pridgen@xxxxxxxxxxxxxxxxxxx>]

Gotcha.  I think I have all the info to do the commit now.  I
appreciate the guidance everyone.

-- Adam

On Sat, Jun 6, 2015 at 11:17 AM, Gerald Combs <gerald@xxxxxxxxxxxxx> wrote:
> Short answer: Go to https://code.wireshark.org/review/login/ and log in
> using your Google, GitHub, or an OpenID account.
>
> The long answer involves OpenID, OAuth, a group in very large company
> deprecating one of its authentication services, a different group in
> *that same very large company* refusing to adopt the recommended
> replacement service for its code review system, and a system
> administrator quietly weeping in the night when no one is watching.
>
>
> On 6/6/15 8:22 AM, Adam Pridgen wrote:
>> Anil,
>>
>> Thanks for the break down.  One final question, how do I set up an
>> account to submit code.wireshark.com, or do I even need too?  Thanks,
>>
>> -- Adam
>>
>> On Sat, Jun 6, 2015 at 3:10 AM, Anil <anilkumar911@xxxxxxxxx> wrote:
>>> Adam,
>>>
>>> I recently submitted some code to wireshark. I found that the process is
>>> simple. Can you share the link where you found the instructions?
>>>
>>> This is what I do (This may have some mistakes, but it worked).
>>>
>>> 1) git clone
>>>       git clone https://code.wireshark.org/review/wireshark
>>>
>>> 2) Install the commit-msg hook. This is required to generate the 'Change-Id'
>>> in the commit message
>>>     a. get it from https://code.wireshark.org/review/tools//hooks/commit-msg
>>>     b. copy it to <source_tree>/.git/hooks/commit-msg
>>>
>>> 3) Create a branch with appropriate name that describes your change
>>>     ex: git checkout -b tls11_dec_pms
>>>
>>> 4) make changes and commit them locally with appropriate comment. The
>>> commit-msg hook will add the change-id.
>>>
>>> 5) Submit the change for review using 'git push'
>>>
>>> git push ssh://anilkumar911@xxxxxxxxxxxxxxxxxx:29418/wireshark
>>> HEAD:refs/for/master/tls11_dec_pms
>>>
>>>
>>> If you make further changes over the originally submitted change, run 'git
>>> rebase -i origin', and choose 'squash' on newer changes, so that there is a
>>> single change (do this after committing the newer changes locally). Then run
>>> the command in step 5 above.
>>>
>>> --Anil
>>>
>>> On Sat, Jun 6, 2015 at 1:39 AM, Adam Pridgen
>>> <adam.pridgen@xxxxxxxxxxxxxxxxxxx> wrote:
>>>>
>>>> Hello,
>>>>
>>>> I would like to make a minor code contribution that allows TLS1.1/1.2
>>>> traffic to be decrypted with a known PMS.  I have read over the
>>>> Gerritt submission process twice, and I am not sure how I can submit
>>>> my changes back to Wireshark.
>>>>
>>>> For the time being, I have posted them up to GitHub
>>>> (https://github.com/deeso/wireshark).  Is there an "easy" button for
>>>> submitting features if I only intend to make a single contribution?
>>>> Thanks,
>>>>
>>>> -- Adam
>>>>
>>>> ___________________________________________________________________________
>>>> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>>>> Archives:    https://www.wireshark.org/lists/wireshark-dev
>>>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>>>>
>>>> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>>>
>>>
>>>
>>> ___________________________________________________________________________
>>> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>>> Archives:    https://www.wireshark.org/lists/wireshark-dev
>>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>>>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>> ___________________________________________________________________________
>> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>> Archives:    https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe