Wireshark-dev: Re: [Wireshark-dev] [Wireshark-bugs] [Bug 10750] Use of GdkPixdata / gdk_pixbuf_
Hi Stephen,
2015-01-07 19:31 GMT+01:00 Stephen Fisher <sfisher@xxxxxxx>:
> On Wed, Jan 07, 2015 at 06:21:06PM +0000, bugzilla-daemon@xxxxxxxxxxxxx wrote:
>> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10750
>>
>> --- Comment #7 from Balint Reczey <balint@xxxxxxxxxxxxxxx> ---
>> (In reply to Stephen Fisher from comment #6)
>> > Distribution sources really shouldn't disable deprecated functions like
>> > that; only developer ones should to remind us to update the functions.
>> > However Wireshark doesn't have an (easy) way to change that so I'm going to
>> > the remove -DDISABLE_DEPRECATED flag shortly as well as backporting it.
>>
>> Please don't do that. Distributions are free to patch out the
>> deprecations and I regularly do that when it is needed for all Debian
>> derivatives.
>
> But why should they have to? And what about users who build from
> regular source distributions of Wireshark? Developers using
> -DDISABLE_DEPRECATED just buys us a reminder when something suddenly
> becomes deprecated in a newer version by breaking it and waiting for a
> fix, but for users it causes headache trying to either remove that flag
> or downgrade the software (in this case gdk-pixbuf). I had another
> piece of software get hit by this same problem last week, so I ended up
> going the lazy route and downgrading gdk-pixbuf.
IMO integration is the distributions' package maintainers job and
disabling such reminders is one of their decisions to make or not
make. I would prefer keeping them when wearing any of my Wireshark Dev
and my Debian Dev hats.
Removing usages of the deprecated functions is on my TODO list, but if
I can't finish that in reasonable time keeping the reminder would help
others to act.
Deprecated functions are usually removed in a few releases and we
should be prepared for the removal.
Cheers,
Balint
