Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master b0e6fbf: umts_fp: Replace se_new0
This is an init routine, which can be called when no file is in scope,
so wmem_file_scope() is incorrect (and se_* was also incorrect).
I'm actually not sure what this routine is doing, since it deals with
conversations but there will never be any conversations e.g. on
startup when the init routine is actually called...
On Wed, Dec 31, 2014 at 11:11 AM, Wireshark code review
<code-review-do-not-reply@xxxxxxxxxxxxx> wrote:
> URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b0e6fbf2d4ac4c5819d09b2a5072e74436b4f1c8
> Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
> Changed: branch: master
> Repository: wireshark
>
> Commits:
>
> b0e6fbf by Bill Meier (wmeier@xxxxxxxxxxx):
>
> umts_fp: Replace se_new0(...) by wmem_new0(wmem_file_scope(), ...)
>
> Change-Id: I9d40ffd199147fb8b975c493253d5cf796be5983
> Reviewed-on: https://code.wireshark.org/review/6179
> Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
>
>
> Actions performed:
>
> from f7b6dcc Lua: allow a Dissector object to be passed in for register_heuristic
> adds b0e6fbf umts_fp: Replace se_new0(...) by wmem_new0(wmem_file_scope(), ...)
>
>
> Summary of changes:
> epan/dissectors/packet-umts_fp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ___________________________________________________________________________
> Sent via: Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
> mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe
