Wireshark · Wireshark-dev: Re: [Wireshark-dev] Change in wireshark[master]: Bring pkg.m4 in from pkgconfig version 0.28 so we c

[Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>]

On Fri, Dec 19, 2014 at 10:05 AM, Anders Broman <anders.broman@xxxxxxxxxxxx> wrote:

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Stephen Fisher
Sent: den 19 december 2014 00:45
To: wireshark-dev@xxxxxxxxxxxxx
Subject: Re: [Wireshark-dev] Change in wireshark[master]: Bring pkg.m4 in from pkgconfig version 0.28 so we can use th...

>When the petri dish fails on pre-commit hook and it says "Pre-commit hook script is outdated, please update!" does that mean mine was outdated and missed something or the one on the petri dish builder is >outdated?

It means that there is a newer pre-commit version in tools that you need to copy to ./git/hooks/

I need to look how to disable the check for Petri-Dish..

Petri Dish launch directly the script for tools/pre-commit (and the script is no copy in .git/hooks)

Regards
Anders

On Thu, Dec 18, 2014 at 10:33:21PM +0000, Petri Dish Buildbot (Code Review) wrote:
> Petri Dish Buildbot has posted comments on this change.
>
> Change subject: Bring pkg.m4 in from pkgconfig version 0.28 so we can
> use the PKG_PROG_PKG_CONFIG macro to try searching for pkg-config even when it isn't installed.  Without this (and without pkg-config installed) the configure script is broken.  With it, it gives a mes ......................................................................
>
>
> Patch Set 1: Verified-1
>
> Builder Ubuntu x86-64 Petri Dish failed (failed Pre-commit check) -
> http://buildbot.wireshark.org/petri-dish/builders/Ubuntu%20x86-64%20Pe
> tri%20Dish/builds/947
>
> Builder Windows x86 Petri Dish succeeded (build successful) -
> http://buildbot.wireshark.org/petri-dish/builders/Windows%20x86%20Petr
> i%20Dish/builds/933
>
> --
> To view, visit https://code.wireshark.org/review/5671
> To unsubscribe, visit https://code.wireshark.org/review/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I4c5af4cedd8c1927c1e00dd6b42faef3f31b84d4
> Gerrit-PatchSet: 1
> Gerrit-Project: wireshark
> Gerrit-Branch: master
> Gerrit-Owner: Stephen Fisher <sfisher@xxxxxxx>
> Gerrit-Reviewer: Michael Mann <mmann78@xxxxxxxxxxxx>
> Gerrit-Reviewer: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
> Gerrit-HasComments: No
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe