Wireshark-dev: Re: [Wireshark-dev] CMake support out of source plugin compilation
Thank you all for spending the time to review my patches and provide feedback.
I think this were all changes required for out-of-source plugin/dissector
compilation.
Feel free to contact me when problems arise or when reviews (on this
subject/code) are needed.
Thanks,
Maarten
On Tuesday 16 December 2014 09:24:50 mmann78@xxxxxxxxxxxx wrote:
> I've kicked off the Petri-Dish for most (all?) of the changes. Am I correct
> in understanding most of the patches introduce "optional" features, so they
> shouldn't break existing cmake user setups (of platforms the Petri-Dish
> doesn't have)?
>
> Michael
>
>
>
> -----Original Message-----
> From: Maarten Bezemer <maarten.bezemer@xxxxxxxxx>
> To: wireshark-dev <wireshark-dev@xxxxxxxxxxxxx>
> Sent: Tue, Dec 16, 2014 5:29 am
> Subject: Re: [Wireshark-dev] CMake support out of source plugin compilation
>
> On Thursday 20 November 2014 14:37:26 you wrote:
> > On Thursday 20 November 2014 13:26:29 Bálint Réczey wrote:
> > > I was waiting for Jörg to comment on the change, but I have submitted
> > > it instead:
> > > https://code.wireshark.org/review/#/c/5316/
> >
> > I saw, also that my two related patches are abandoned.
> > I was wondering about my actual 'out of source' patches.
> >
> > But as already mentioned by Graham Bloice, there are some (lack of) spare
> > time issues. So, I will just wait until time permits to proper look
> > at/review them.
>
> It has been a while. Is there any chance these patches are going to be
> accepted?
>
> If not (soon), that is fine by me a well. I'll just create a PPA and put
> Wireshark with my patches in it. So we can (start) use(ing) the
> out-of-source builds over here.
>
> Regards,
> Maarten
> ___________________________________________________________________________
> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
