Wireshark-dev: Re: [Wireshark-dev] proto_tree_add_uint vs. proto_tree_add_item
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Date: Fri, 29 Aug 2014 18:48:02 +0200


Le 29 août 2014 18:33, "Thomas Wiens" <th.wiens@xxxxxx> a écrit :
>
> Hi,
>
> I've got a comment in the code review, that I can use
> proto_tree_add_item instead of proto_tree_add_uint.
>
> I have used proto_tree_add_uint() when the value which is added is
> needed for packet dissection (e.g. to decide which path is to follow).
>
> Should I change all of my proto_tree_add_uint() to proto_tree_add_item()?
>
> My thought was, that with proto_tree_add_uint the value has only to be
> peeked once out of tvbuff.
>
> --
> Regards,
> Thomas

Hi Thomas,
I'm often doing the same thing myself: it avoids fetching twice the same value. That said the overhead must be quite small but personally I consider your code as correct.

Regards,
Pascal.