Wireshark-dev: Re: [Wireshark-dev] Gerrit patches with trailing whitespace
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
Date: Mon, 25 Aug 2014 20:06:13 +0100
On 25 August 2014 20:03, Joerg Mayer <jmayer@xxxxxxxxx> wrote:
On Mon, Aug 25, 2014 at 06:06:15PM +0100, Graham Bloice wrote:
> When reviewing some submissions on Gerrit, I've noted a few with trailing
> whitespace.  The git pre-commit hook always warns me of this, so how are
> folks managing to do this?  Are they using clients that ignore the hook?

How about adding a test to our build systems:

 If we are part of a git repo and .git/hooks/pre-commit doesn't exist
 then print a message at the end of the build that in case of an intended
 submission the file should be installed first.


+1 



--
Graham Bloice