Wireshark-dev: Re: [Wireshark-dev] Adding a new dissector - beginners guide
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Bill Meier <wmeier@xxxxxxxxxxx>
Date: Fri, 22 Aug 2014 10:44:43 -0400
On 8/22/2014 10:15 AM, Thomas Wiens wrote:

On 22 August 2014 16:05, wrote Graham Bloice:


As I noted on the review, I think you must have removed the Change-ID: line
from the commit message that Gerrit uses to track a new patch set for an
existing change.

You should have used `git commit --amend` to commit and use the existing
commit message.  See the "Amending a change" section in
http://wiki.wireshark.org/Development/SubmittingPatches

To recover this, we can either consider the latest change as the "primary"
change and abandon the older one (which would effectively throw away Bill's
fine comments) or abandon the new change and resubmit your changes as a new
patch set to the older change.


If it's possible to abandon the new change.
What should I do?
I think, I'll have to go back to the old change-id-version, and then
apply my changes again with "git commit --amend".

How do I get back to the old version?



See my comment to you on the new patch

https://code.wireshark.org/review/#/c/3794/