Wireshark-dev: Re: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
Date: Fri, 15 Aug 2014 20:36:06 +0100
On 15 August 2014 20:17, Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> wrote:
Hi folks,

One thing I've noticed about the Petri-Dish flag in Gerrit is that every time I set it to +1 I get an error saying "needs code review."  Since Chris just noticed and complained about that too (on change 3624) I thought I'd mention it here.


I haven't seen that when I've set the Petri-dish flag.

I do have difficulty forcing a subsequent Petri-Dish build after the first one though, does anyone know the incantations for that?

Also re. Chris's comment on 3624, I don't think we have auto-merge running yet.  The item has to be at + 2 and then you can hit the Submit button.  There is no mandatory Petri-Dish flag yet.



--
Graham Bloice