Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master 8da72cd: Fix support for decrypting 802.11 broadcast

[Evan Huus <eapache@xxxxxxxxx>]

The "IEEE 802.11 WPA PSK Decryption" step of our test suite has been failing on the buildbot since this was merged. Dom, can you take a look please?

Thanks,
Evan

On Fri, Aug 8, 2014 at 10:17 AM, Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx> wrote:

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8da72cd43dcd597c9f03754831d55211a17f077c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8da72cd by Dom Gifford (Dominic.Gifford@xxxxxxxxx):

    Fix support for decrypting 802.11 broadcast messages.

    A little bit of guess work is involved as the group key can use a
    different cipher to the pairwise key, and we are trying to do this
    purely based on the EAPOL messages with no prior knowledge of the
    associate request. We try to guess the cipher based on the lengths.

    Bug:8734
    Change-Id: I4c456b45939c00a9d1122406891f704fa037349c
    Reviewed-on: https://code.wireshark.org/review/3183
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>


Actions performed:

    from  345a1d2   ISIS: Fix reachability IPv4 Interface/Neighbor (wrong length)
    adds  8da72cd   Fix support for decrypting 802.11 broadcast messages.


Summary of changes:
 epan/crypt/airpdcap.c |   54 +++++++++++++++++++++++++++++++++++++------------
 1 file changed, 41 insertions(+), 13 deletions(-)
___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe