Wireshark-dev: [Wireshark-dev] [PATCH] fix a Buffer overrun possible for long command line argu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Toralf Förster <toralf.foerster@xxxxxx>
Date: Sun, 3 Aug 2014 20:20:04 +0200
cpotted by cppcheck

Signed-off-by: Toralf Förster <toralf.foerster@xxxxxx>
---
 epan/dissectors/dcerpc/idl2wrs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/epan/dissectors/dcerpc/idl2wrs.c b/epan/dissectors/dcerpc/idl2wrs.c
index 8c4f73b..89c1eb0 100644
--- a/epan/dissectors/dcerpc/idl2wrs.c
+++ b/epan/dissectors/dcerpc/idl2wrs.c
@@ -3184,7 +3184,7 @@ int main(int argc, char *argv[])
 	eth_ft=fopen("ETH_FT", "w");
 	eth_handoff=fopen("ETH_HANDOFF", "w");
 
-	sprintf(idlfile, "%s.cnf", argv[1]);
+	snprintf(idlfile, "%s.cnf", sizeof(idlfile)-4, argv[1]);
 	fh=fopen(idlfile,"r");
 	if(fh){
 		readcnffile(fh);
-- 
2.0.4