Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master 6b11cd9: Make Lua taps work in out-of-source-tree bui

[Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>]

Ahhh...  The problem is cmake puts the generated files in the wrong 
directory (epan/ instead of epan/wslua/).

>     /* load system's init.lua */
>     if (running_in_build_directory()) {
>         /* Running from build directory, load generated file */
>         filename = g_strdup_printf("%s" G_DIR_SEPARATOR_S "epan" G_DIR_SEPARATOR_S "wslua"
>                                    G_DIR_SEPARATOR_S "init.lua", get_progfile_dir());

I saw that when doing this change (I even tried to move the output of 
make-taps.pl into the wslua directory when making the below change only 
to find that the directory doesn't even exist in the build directory).

I'll leave that to someone who understands cmake...

On 08/01/2014 09:10 PM, Evan Huus wrote:
> Thanks Jeff, this gets me farther however lua out-of-tree is still
> failing for me, and it's actually because it can't find init.lua this
> time :)
>
> The error I am getting is: attempt to call global 'typeof' (a nil value)
>
> typeof is a function defined in init.lua (which is in ${BUILD_DIR}/epan/
> for me using cmake).
>
>
>
> On Fri, Aug 1, 2014 at 9:00 PM, Wireshark code review
> <code-review-do-not-reply@xxxxxxxxxxxxx
> <mailto:code-review-do-not-reply@xxxxxxxxxxxxx>> wrote:
>
>     URL:
>     https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6b11cd97f2153bb015ade6efd05929999de85457
>     Submitter: Evan Huus (eapache@xxxxxxxxx <mailto:eapache@xxxxxxxxx>)
>     Changed: branch: master
>     Repository: wireshark
>
>     Commits:
>
>     6b11cd9 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx
>     <mailto:jeff.morriss.ws@xxxxxxxxx>):
>
>          Make Lua taps work in out-of-source-tree builds.
>
>     make-taps.pl <http://make-taps.pl> needs to know where to find the
>     source files otherwise none of
>          the tap data gets built correctly.
>
>          This makes the wslua test suite run in out-of-source-tree
>     builds too.
>
>          Change-Id: I059474d90d59e87bd57dba18530a66a927a014cf
>          Reviewed-on: https://code.wireshark.org/review/3337
>          Reviewed-by: Evan Huus <eapache@xxxxxxxxx
>     <mailto:eapache@xxxxxxxxx>>
>
>
>     Actions performed:
>
>          from  69d0788   CompiledFilterOutput dialog fixes and updates.
>          adds  6b11cd9   Make Lua taps work in out-of-source-tree builds.