Wireshark-dev: Re: [Wireshark-dev] Backport request for proto_tree_add_subtree[_format]
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Thu, 10 Jul 2014 15:47:49 -0700
On Jul 10, 2014, at 2:18 PM, Peter Wu <peter@xxxxxxxxxxxxx> wrote:

> I would like to have the proto_tree_add_subtree and 
> proto_tree_add_subtree_format functions backported to master-1.12. Any objects 
> to that? It is only a new addition to the API, so it should be pretty safe.
> 
> It should make backporting changes easier. (read: backport a refactoring (WIP) 
> to reduce code duplication in the SSL and DTLS dissectors.)

If the refactoring merely cleans up working code, producing code that doesn't appear different to the end user (old code dissects as well as new code, crashes no more than new code, etc.), it's probably not worth backporting it.

If the refactoring fixes bugs, or makes it easier to fix existing bugs, that might make it worth backporting.